feat(aws-autoscaling): Add support for termination policies#17936
Merged
mergify[bot] merged 6 commits intoaws:masterfrom Dec 29, 2021
nwalters512:feat/asg-termination-policy
Merged
feat(aws-autoscaling): Add support for termination policies#17936mergify[bot] merged 6 commits intoaws:masterfrom nwalters512:feat/asg-termination-policy
mergify[bot] merged 6 commits intoaws:masterfrom
nwalters512:feat/asg-termination-policy
Conversation
|
|
comcalvi
previously approved these changes
Dec 29, 2021
Contributor
|
Conditional approval on adding a section to the README to satisfy the linter. |
Pull request has been modified.
Contributor
Author
|
@comcalvi I just added a small section to the README! |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
comcalvi
approved these changes
Dec 29, 2021
Contributor
comcalvi
left a comment
There was a problem hiding this comment.
Thanks for the readme update!
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This PR adds support for [termination policies](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-termpolicy) to the `AutoScalingGroup` resource. `aws autoscaling describe-termination-policy-types --region us-east-2` reports the existence of a `Lambda` termination type, but that isn't documented in the CloudFormation docs, so I opted to omit it. Closes aws#15654.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for termination policies to the
AutoScalingGroupresource.aws autoscaling describe-termination-policy-types --region us-east-2reports the existence of aLambdatermination type, but that isn't documented in the CloudFormation docs, so I opted to omit it.Closes #15654.