feat(lambda-event-sources): adds AuthenticationMethod.CLIENT_CERTIFICATE_TLS_AUTH to kafka#17920
Conversation
|
|
42e5e6e to
deb87b0
Compare
kaizencc
left a comment
There was a problem hiding this comment.
Thanks for submitting the contribution @oieduardorabelo! Minor comment below. LGTM!
| authType = lambda.SourceAccessConfigurationType.BASIC_AUTH; | ||
| break; | ||
| case AuthenticationMethod.CLIENT_CERTIFICATE_TLS_AUTH: | ||
| authType = lambda.SourceAccessConfigurationType.of(AuthenticationMethod.CLIENT_CERTIFICATE_TLS_AUTH); |
There was a problem hiding this comment.
can you add this as a static method to lambda.SourceAccessConfigurationType also? Not sure why there's this duplicate between AuthenticationMethod and lambda.SourceAccessConfigurationType but there's nothing we can do about it now.
There was a problem hiding this comment.
@kaizen3031593 I have updated the PR with the new static method. Thank you for reviewing it 💪
5eb4559 to
ed1837f
Compare
kaizencc
left a comment
There was a problem hiding this comment.
One more minor thing :)
| public static readonly SASL_SCRAM_512_AUTH = new SourceAccessConfigurationType('SASL_SCRAM_512_AUTH'); | ||
|
|
||
| /** | ||
| * The Secrets Manager ARN of your secret key containing the certificate chain (X.509 PEM), private key (PKCS#8 PEM), and private key password (optional) used for mutual TLS authentication of your MSK/Apache Kafka brokers. |
There was a problem hiding this comment.
Last thing -- sorry I would do this myself but I don't think I can change code in your PR since you are developing on master... next time, if you dev on a branch, I should have default permissions to go in and change things if necessary.
What I would like to see here is to have this broken up into two lines for readability. As soon as you do it, I'll approve!
There was a problem hiding this comment.
oh thanks for the tip around branches, I'll keep that in mind 👍 new line on the comment was added in last commit
293238f to
ad4f2f1
Compare
kaizencc
left a comment
There was a problem hiding this comment.
🥳 thanks for the contribution!
AuthenticationMethod.CLIENT_CERTIFICATE_TLS_AUTH to kafka
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hi @oieduardorabelo, Thanks for implementing this. Is it possible to add SERVER_ROOT_CA_CERTIFICATE to SourceAccessConfigurationType as well please in python CDK? Thanks |
|
Hi There AWS team (@oieduardorabelo / @kaizen3031593 ), |
…CATE_TLS_AUTH` to kafka (aws#17920) This PR adds a new enum value, `CLIENT_CERTIFICATE_TLS_AUTH`, to `SelfManagedKafkaEventSource`. [Docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-eventsourcemapping-sourceaccessconfiguration.html). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds a new enum value,
CLIENT_CERTIFICATE_TLS_AUTH, toSelfManagedKafkaEventSource.Docs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license