chore(lambda-nodejs): fix test broken in CodeBuild#17884
Merged
mergify[bot] merged 1 commit intomasterfrom Dec 7, 2021
Merged
Conversation
This test fails in our CodeBuild environment with the following error:
```
FAIL test/util.test.js
● extractDependencies › with file dependency
expect(received).toEqual(expected) // deep equality
- Expected - 1
+ Received + 1
Object {
- "my-module": StringMatching /aws-cdk\/packages\/@aws-cdk\/core/,
+ "my-module": "file:/codebuild/output/src777018412/src/packages/@aws-cdk/core",
}
130 | }));
131 |
> 132 | expect(extractDependencies(pkgPath, ['my-module'])).toEqual({
| ^
133 | 'my-module': expect.stringMatching(/aws-cdk\/packages\/@aws-cdk\/core/),
134 | });
135 |
at Object.<anonymous> (test/util.test.ts:132:57)
```
This is due to the source being located in .../src instead of .../aws-cdk. Fix
the test by stopping the check at the 'packages' directory.
|
|
corymhall
approved these changes
Dec 7, 2021
Contributor
Author
|
@Mergifyio backport v2-main |
Contributor
🟠 Waiting for conditions to matchDetails
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
This test fails in our CodeBuild environment with the following error:
```
FAIL test/util.test.js
● extractDependencies › with file dependency
expect(received).toEqual(expected) // deep equality
- Expected - 1
+ Received + 1
Object {
- "my-module": StringMatching /aws-cdk\/packages\/@aws-cdk\/core/,
+ "my-module": "file:/codebuild/output/src777018412/src/packages/@aws-cdk/core",
}
130 | }));
131 |
> 132 | expect(extractDependencies(pkgPath, ['my-module'])).toEqual({
| ^
133 | 'my-module': expect.stringMatching(/aws-cdk\/packages\/@aws-cdk\/core/),
134 | });
135 |
at Object.<anonymous> (test/util.test.ts:132:57)
```
This is due to the source being located in .../src instead of .../aws-cdk. Fix
the test by stopping the check at the 'packages' directory.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
(cherry picked from commit d5c249f)
Contributor
✅ Backports have been createdDetails
|
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2021
…17885) This is an automatic backport of pull request #17884 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This test fails in our CodeBuild environment with the following error:
```
FAIL test/util.test.js
● extractDependencies › with file dependency
expect(received).toEqual(expected) // deep equality
- Expected - 1
+ Received + 1
Object {
- "my-module": StringMatching /aws-cdk\/packages\/@aws-cdk\/core/,
+ "my-module": "file:/codebuild/output/src777018412/src/packages/@aws-cdk/core",
}
130 | }));
131 |
> 132 | expect(extractDependencies(pkgPath, ['my-module'])).toEqual({
| ^
133 | 'my-module': expect.stringMatching(/aws-cdk\/packages\/@aws-cdk\/core/),
134 | });
135 |
at Object.<anonymous> (test/util.test.ts:132:57)
```
This is due to the source being located in .../src instead of .../aws-cdk. Fix
the test by stopping the check at the 'packages' directory.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails in our CodeBuild environment with the following error:
This is due to the source being located in .../src instead of .../aws-cdk. Fix
the test by stopping the check at the 'packages' directory.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license