feat(iotevents): add IoT Events input L2 Construct#17847
feat(iotevents): add IoT Events input L2 Construct#17847mergify[bot] merged 7 commits intoaws:masterfrom
Conversation
|
|
|
Hi @minche-tsai are you able to take a first look? |
skinny85
left a comment
There was a problem hiding this comment.
Looks great as always @yamatatsu! A few minor comments.
| /** | ||
| * The name of the input | ||
| * | ||
| * @default xxx |
| /** | ||
| * Defines an AWS IoT Events input in this stack. | ||
| */ | ||
| export class Input extends Resource { |
There was a problem hiding this comment.
Looks like we're missing the IInput interface for Input.
| const resource = new CfnInput(this, 'Resource', { | ||
| inputName: this.physicalName, | ||
| inputDefinition: { | ||
| attributes: props.attributeJsonPaths.map(path => ({ jsonPath: path })), |
There was a problem hiding this comment.
Can attributeJsonPaths be empty? If not, can we validate that it's not? If it can be empty, can we make it optional, and default to []?
There was a problem hiding this comment.
As you said, attributeJsonPaths can not be empty. So I've been thinking that it is better to validate it too!
On the other hand, I thought I had to make my initial L2 PR smaller so as not to repeat my previous mistakes😅 .
I never mind which ways, implement in this PR or after! 😉
I've fixed it!
Pull request has been modified.
skinny85
left a comment
There was a problem hiding this comment.
Fantastic work @yamatatsu!
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This is proposed by aws#17711. This PR was created for implemeting `Input` L2 Construct. Implementing it is needed before `DetectorModel`. The reason is described in here: aws#17711 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is proposed by #17711.
This PR was created for implemeting
InputL2 Construct. Implementing it is needed beforeDetectorModel. The reason is described in here: #17711 (comment)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license