Skip to content

feat(rds): parameter group for replica instances#17822

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
jogold:rds-replica-param-group
Dec 3, 2021
Merged

feat(rds): parameter group for replica instances#17822
mergify[bot] merged 2 commits intoaws:masterfrom
jogold:rds-replica-param-group

Conversation

@jogold
Copy link
Copy Markdown
Contributor

@jogold jogold commented Dec 3, 2021

Move parameterGroup from DatabaseInstanceSourceProps to
DatabaseInstanceNewProps since the parameter group of a replica
instance can be customized.

Closes #17580


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 3, 2021

@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Dec 3, 2021
@jogold
Copy link
Copy Markdown
Contributor Author

jogold commented Dec 3, 2021

pr-linter/exempt-readme please

@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 3, 2021
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as always, thanks @jogold!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: db7491e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b606a23 into aws:master Dec 3, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

eastNine pushed a commit to eastNine/aws-cdk that referenced this pull request Dec 5, 2021
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@jogold jogold deleted the rds-replica-param-group branch December 5, 2021 14:15
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Move `parameterGroup` from `DatabaseInstanceSourceProps` to
`DatabaseInstanceNewProps` since the parameter group of a replica
instance can be customized.

Closes aws#17580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-rds Related to Amazon Relational Database pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDS: change parameterGroup prop for DatabaseInstanceReadReplica

3 participants