chore(assertions): snippets avoid using intermediate variable assignment#17714
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 25, 2021
Merged
chore(assertions): snippets avoid using intermediate variable assignment#17714mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
Previously, the rosetta translations could not determine the type of objects being passed into methods when they are untyped. Some were being interpreted as 'props' type while they should just be regarding as `Record` or `any`. To compensate for this, the README in this module assigned them to variables, so the translator did a better job at knowing this. This has now been fixed in rosetta. Move back to using this inline, since the usage is just nicer.
|
|
rix0rrr
approved these changes
Nov 25, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
beezly
pushed a commit
to beezly/aws-cdk
that referenced
this pull request
Nov 29, 2021
…ent (aws#17714) Previously, the rosetta translations could not determine the type of objects being passed into methods when they are untyped. Some were being interpreted as 'props' type while they should just be regarding as `Record` or `any`. To compensate for this, the README in this module assigned them to variables, so the translator did a better job at knowing this. This has now been fixed in rosetta. Move back to using this inline, since the usage is just nicer. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ent (aws#17714) Previously, the rosetta translations could not determine the type of objects being passed into methods when they are untyped. Some were being interpreted as 'props' type while they should just be regarding as `Record` or `any`. To compensate for this, the README in this module assigned them to variables, so the translator did a better job at knowing this. This has now been fixed in rosetta. Move back to using this inline, since the usage is just nicer. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the rosetta translations could not determine the type of
objects being passed into methods when they are untyped. Some were being
interpreted as 'props' type while they should just be regarding as
Recordorany.To compensate for this, the README in this module assigned them to
variables, so the translator did a better job at knowing this.
This has now been fixed in rosetta. Move back to using this inline,
since the usage is just nicer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license