fix(appmesh): adding support with gateway route priority#17694
fix(appmesh): adding support with gateway route priority#17694mergify[bot] merged 4 commits intoaws:masterfrom
Conversation
|
|
|
I am also requesting to have at least one review from the service team. |
skinny85
left a comment
There was a problem hiding this comment.
Looks great @Seiya6329! A few small comments.
| }); | ||
|
|
||
| describe('with priority', () => { | ||
| test('setting priority using the method', () => { |
There was a problem hiding this comment.
I don't think it makes sense to categorize tests on how the Route gets added.
I think a better idea is to have a separate test per Route type (so, one for http, one for http2, and one for grpc).
There was a problem hiding this comment.
I like this idea. I will work on sorting the tests as advised.
Pull request has been modified.
rishijatia
left a comment
There was a problem hiding this comment.
Have two comments, relatively minor, looks good otherwise.
0383d90 to
cf6bb1a
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adding the Gateway Route `Priority` support. This is not a new feature but it was missed from the implementation. The implementation method is mimicking how Route's `Priority` is implemented: - [route-spec.ts](https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-appmesh/lib/route-spec.ts) - [route.ts](https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-appmesh/lib/route.ts) Fixes aws#16821 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adding the Gateway Route
Prioritysupport. This is not a new feature but it was missed from the implementation.The implementation method is mimicking how Route's
Priorityis implemented:Fixes #16821
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license