fix(logs): log retention fails with OperationAbortedException#17688
fix(logs): log retention fails with OperationAbortedException#17688mergify[bot] merged 2 commits intoaws:masterfrom
Conversation
|
|
comcalvi
left a comment
There was a problem hiding this comment.
Looks great! One minor gripe, but this is pretty much good to be merged in.
| } | ||
| } | ||
| // Any other error | ||
| console.error(error); |
There was a problem hiding this comment.
I know createLogGroupSafe() does this as well, but let's remove these console statements.
There was a problem hiding this comment.
Should I remove them from createLogGroupSafe() as well?
There was a problem hiding this comment.
I removed it from both places, since the error gets caught and logged in the calling method.
d7ac4df to
04cfa30
Compare
Pull request has been modified.
|
Can't wait for this to be in a version! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
) Fixes: aws#17546 This adds to the fix in aws#16083 that was addressing the issue where the LogRetention Lambda can be executed concurrently and create a race condition where multiple invocations are trying to create or modify the same log group. The previous fix addressed the issue if it occurred during log group creation, in the `createLogGroupSafe` method, but did not account for the same problem happening when modifying a log group's retention period in the `setRetentionPolicy` method. This fix applies the same logic from the last fix to the other method. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes: #17546
This adds to the fix in #16083 that was addressing the issue where the LogRetention Lambda can be executed concurrently and create a race condition where multiple invocations are trying to create or modify the same log group.
The previous fix addressed the issue if it occurred during log group creation, in the
createLogGroupSafemethod, but did not account for the same problem happening when modifying a log group's retention period in thesetRetentionPolicymethod. This fix applies the same logic from the last fix to the other method.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license