feat(ec2): add mac1 instance#17677
Conversation
|
|
ae1bf7d to
b8ac6f1
Compare
|
should we add a similar test like this for aws-cdk/packages/@aws-cdk/aws-ec2/test/instance.test.ts Lines 139 to 149 in 0138292 @neilkuan @kimisme9386 @dwchiang can you take a peek at this? |
|
@pahud Updated tests... however |
|
@pahud - We typically (historically) haven't added tests for enum additions like this. If there's new functionality, then a test is required, but if it's literally "one more value that reacts identically to the other 100", then a test is a bit redundant. @robertd - Given this test isn't totally accurate, I think reverting makes more sense. I can do that on your behalf here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
`mac1` instances got released last year: https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-ec2-mac-instances-additional-regions/ Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype Note: Whenever `mac2` comes out (probably on M1, or most likely on M1Pro/M1Max) we'll have to update `InstanceArchitecture` enum [here](https://github.com/aws/aws-cdk/blob/ddf2881ee24cbf3083463a6e772a5c91acc229aa/packages/%40aws-cdk/aws-ec2/lib/instance-types.ts#L573). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
`mac1` instances got released last year: https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-ec2-mac-instances-additional-regions/ Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype Note: Whenever `mac2` comes out (probably on M1, or most likely on M1Pro/M1Max) we'll have to update `InstanceArchitecture` enum [here](https://github.com/aws/aws-cdk/blob/ddf2881ee24cbf3083463a6e772a5c91acc229aa/packages/%40aws-cdk/aws-ec2/lib/instance-types.ts#L573). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
`mac1` instances got released last year: https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-ec2-mac-instances-additional-regions/ Docs have already been updated a while ago: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype Note: Whenever `mac2` comes out (probably on M1, or most likely on M1Pro/M1Max) we'll have to update `InstanceArchitecture` enum [here](https://github.com/aws/aws-cdk/blob/ddf2881ee24cbf3083463a6e772a5c91acc229aa/packages/%40aws-cdk/aws-ec2/lib/instance-types.ts#L573). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mac1instances got released last year:https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-ec2-mac-instances-additional-regions/
Docs have already been updated a while ago:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype
Note: Whenever
mac2comes out (probably on M1, or most likely on M1Pro/M1Max) we'll have to updateInstanceArchitectureenum here.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license