Skip to content

chore: note about code snippets that uses consumers#17645

Merged
mergify[bot] merged 1 commit intomasterfrom
nija-at/rosetta-note
Nov 23, 2021
Merged

chore: note about code snippets that uses consumers#17645
mergify[bot] merged 1 commit intomasterfrom
nija-at/rosetta-note

Conversation

@nija-at
Copy link
Copy Markdown
Contributor

@nija-at nija-at commented Nov 23, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested review from a team and rix0rrr November 23, 2021 10:28
@nija-at nija-at self-assigned this Nov 23, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 23, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 23, 2021
> of the current module, and hence not present in the current module's dependency closure.
> Compilation of these snippets will fail if the module referenced has not been built.
> For the best experience when working on snippets, a full build of the CDK repo is required.
> However, it may be prudent to "build up" these modules as required.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prudent in what sense? Is it because building up as required usually takes less time than building the whole shebang? I would be more precise about that.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d2b19ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9eedaa0 into master Nov 23, 2021
@mergify mergify bot deleted the nija-at/rosetta-note branch November 23, 2021 11:13
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants