feat(cli): Hotswapping Support for S3 Bucket Deployments#17638
feat(cli): Hotswapping Support for S3 Bucket Deployments#17638mergify[bot] merged 29 commits intoaws:masterfrom
Conversation
…ferent deployment
|
|
skinny85
left a comment
There was a problem hiding this comment.
Looks great! A few minor comments, and we can get this in!
packages/aws-cdk/lib/api/hotswap/evaluate-cloudformation-template.ts
Outdated
Show resolved
Hide resolved
… to the Statement[0].Resource
…ess constructor() definition
skinny85
left a comment
There was a problem hiding this comment.
In general, looks great! A few minor comments.
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
skinny85
left a comment
There was a problem hiding this comment.
In general, looks good! I think a small bug snuck through the previous review, and some small comments, but we are very, very close to merging this one in!
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/test/api/hotswap/s3-bucket-hotswap-deployments.test.ts
Outdated
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds hotswap support for S3 Bucket Deployments. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds hotswap support for S3 Bucket Deployments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license