Skip to content

chore(eks): readme compilation errors#17637

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
kaizencc:eks-fix
Nov 23, 2021
Merged

chore(eks): readme compilation errors#17637
mergify[bot] merged 2 commits intoaws:masterfrom
kaizencc:eks-fix

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 22, 2021

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 22, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 22, 2021
```ts
declare const cluster: eks.Cluster;
const manifest = cluster.addManifest('manifest', {/* ... */});
manifest.node.addDependency(cluster.albController ?? [])
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rix0rrr This was just introduced in #17618, and was a new example (so no cache issues). This error should have been reported by the strict mode enforced on eks if that were working properly. It was also not reported in the build failure on the forward-merge PR, but was reported when I ran yarn rosetta:extract --compile locally.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well shoot!

@kaizencc kaizencc requested a review from rix0rrr November 22, 2021 22:15
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d33e848
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 67da5f3 into aws:master Nov 23, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants