Skip to content

feat(docdb): add option to set the name of the generated Secret#17574

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
markussiebert:feature/docdb-secretname
Nov 22, 2021
Merged

feat(docdb): add option to set the name of the generated Secret#17574
mergify[bot] merged 7 commits intoaws:masterfrom
markussiebert:feature/docdb-secretname

Conversation

@markussiebert
Copy link
Copy Markdown
Contributor

@markussiebert markussiebert commented Nov 18, 2021

fixes: #17572
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 18, 2021

skinny85
skinny85 previously requested changes Nov 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @markussiebert!

The code looks good, we're just missing two things:

  1. Documentation in the ReadMe file of the module showing usage of this property (a one-line change to example code with a comment in the file is fine).
  2. Unit tests (you can look at the existing unit tests in the module for inspiration).

Thanks,
Adam

@mergify mergify bot dismissed skinny85’s stale review November 19, 2021 21:15

Pull request has been modified.

@markussiebert
Copy link
Copy Markdown
Contributor Author

markussiebert commented Nov 21, 2021

@skinny85 sorry - don't know how to ask for a review the official way

@skinny85 skinny85 changed the title feat: add option to set secretName feat(docdb): add option to set the name of the generated Secret Nov 22, 2021
@skinny85 skinny85 self-assigned this Nov 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Nov 22, 2021
@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Nov 22, 2021

@skinny85 sorry - don't know how to ask for a review the official way

For the future 🙂. You need to re-request my review (there's a button right next to my avatar in the top-right corner of the Pull Request web page).

skinny85
skinny85 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @markussiebert, thanks for the contribution!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 22, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4dfaefe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 18c9ef7 into aws:master Nov 22, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@markussiebert @TikiTDO
feat(docdb): add option to set the name of the generated Secret (aws#…
0234bd7 
…17574)

fixes: aws#17572
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skinny85 skinny85 skinny85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skinny85 skinny85

Labels

@aws-cdk/aws-docdb Related to Amazon DocumentDB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(docdb): It should be possible to change the secretName for the created secret

3 participants

@markussiebert @skinny85 @aws-cdk-automation