chore: add integration test to test a construct with a builtin lambda#17571
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Dec 10, 2021
corymhall:corymhall/integ-cr
Merged
chore: add integration test to test a construct with a builtin lambda#17571mergify[bot] merged 2 commits intoaws:masterfrom corymhall:corymhall/integ-cr
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/integ-cr
Conversation
This adds a new integration test that deploys an s3.Bucket with autoDeleteObjects set to true. The autoDeleteObjects feature deploys a Nodejs Lambda backed Custom Resource. Lambda backed custom resources that are included as part of CDK constructs are compiled and bundled as part of the construct library. There are scenarios where this compiled source code (e.g. __entrypoint__.js) could be modified by the build process and cause the lambda execution to fail. This integration test should catch those instances. If the lambda function throws errors during execution the CustomResource will eventually fail. In the integration test this will result in a test timeout and failure.
|
|
otaviomacedo
approved these changes
Dec 10, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…aws#17571) This adds a new integration test that deploys an s3.Bucket with autoDeleteObjects set to true. The autoDeleteObjects feature deploys a Nodejs Lambda backed Custom Resource. Lambda backed custom resources that are included as part of CDK constructs are compiled and bundled as part of the construct library. There are scenarios where this compiled source code (e.g. __entrypoint__.js) could be modified by the build process and cause the lambda execution to fail. This integration test should catch those instances. If the lambda function throws errors during execution the CustomResource will eventually fail. In the integration test this will result in a test timeout and failure. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new integration test that deploys an s3.Bucket with
autoDeleteObjects set to true. The autoDeleteObjects feature deploys a
Nodejs Lambda backed Custom Resource.
Lambda backed custom resources that are included as part of CDK
constructs are compiled and bundled as part of the construct library.
There are scenarios where this compiled source code (e.g.
entrypoint.js) could be modified by the build process and cause the
lambda execution to fail.
This integration test should catch those instances. If the lambda
function throws errors during execution the CustomResource will
eventually fail. In the integration test this will result in a test
timeout and failure.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license