feat(docdb): implement audit and profiler logs#17570
Merged
mergify[bot] merged 30 commits intoaws:masterfrom Nov 24, 2021
markussiebert:feature/docdb-audit-log
Merged
feat(docdb): implement audit and profiler logs#17570mergify[bot] merged 30 commits intoaws:masterfrom markussiebert:feature/docdb-audit-log
mergify[bot] merged 30 commits intoaws:masterfrom
markussiebert:feature/docdb-audit-log
Conversation
|
|
skinny85
previously requested changes
Nov 19, 2021
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the contribution @markussiebert, looks great! A few minor comments.
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Pull request has been modified.
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
skinny85
previously requested changes
Nov 19, 2021
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Looks great @markussiebert! Only minor documentations changes left.
Pull request has been modified.
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
Comment on lines
+131
to
+132
| exportProfilerLogsToCloudWatch: true // Enable sending profiler logs | ||
| exportAuditLogsToCloudWatch: true // Enable sending audit logs |
Contributor
There was a problem hiding this comment.
Suggested change
| exportProfilerLogsToCloudWatch: true // Enable sending profiler logs | |
| exportAuditLogsToCloudWatch: true // Enable sending audit logs | |
| exportProfilerLogsToCloudWatch: true, // Enable sending profiler logs | |
| exportAuditLogsToCloudWatch: true, // Enable sending audit logs |
skinny85
reviewed
Nov 24, 2021
skinny85
reviewed
Nov 24, 2021
skinny85
approved these changes
Nov 24, 2021
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the contribution @markussiebert!
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
beezly
pushed a commit
to beezly/aws-cdk
that referenced
this pull request
Nov 29, 2021
closes aws#17478 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
closes aws#17478 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17478
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license