Skip to content

chore(cli): set User-Agent header for watch and hotswap#17554

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:watch-metrics
Nov 18, 2021
Merged

chore(cli): set User-Agent header for watch and hotswap#17554
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:watch-metrics

Conversation

@skinny85
Copy link
Copy Markdown
Contributor

Use the User-Agent header of the AWS JS SDKs to record when the cdk watch command is invoked,
and also when a hotswap deployment happens (and when it was requested, but we had to fall back on a CFN deployment).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from rix0rrr November 18, 2021 01:23
@skinny85 skinny85 self-assigned this Nov 18, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 18, 2021

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 18, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 18, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 18, 2021
@rix0rrr
Copy link
Copy Markdown
Contributor

rix0rrr commented Nov 18, 2021

Provisional approval

Use the User-Agent header of the AWS JS SDKs to record when the `cdk watch` command is invoked,
and also when a `hotswap` deployment happens (and when it was requested, but we had to fall back on a CFN deployment).
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Nov 18, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5566058
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 557f9c3 into aws:master Nov 18, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the watch-metrics branch November 18, 2021 22:54
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Use the User-Agent header of the AWS JS SDKs to record when the `cdk watch` command is invoked,
and also when a `hotswap` deployment happens (and when it was requested, but we had to fall back on a CFN deployment).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants