fix(cloudwatch): render agnostic alarms in legacy style#17538
Merged
mergify[bot] merged 6 commits intomasterfrom Nov 17, 2021
Merged
fix(cloudwatch): render agnostic alarms in legacy style#17538mergify[bot] merged 6 commits intomasterfrom
mergify[bot] merged 6 commits intomasterfrom
Conversation
Render legacy style alarms even if the user explicitly passes in the `Aws.ACCOUNT_ID` token: we can compare these strings since we every call to `Aws.ACCOUNT_ID` is guaranteed to return the same tokenized string. Only switch to modern-style alarms if we cannot successfully determine that they are definitely equal. This simplifies one more case that would accidentally trigger new-style alarms, which some SNS notification consumers are not equipped to handle. Add a section to the README explaining the differences between old and new-style alarms, and that SNS consumers need to pay attention to the differences.
|
|
Floocs
reviewed
Nov 17, 2021
Floocs
reviewed
Nov 17, 2021
Floocs
approved these changes
Nov 17, 2021
…-cdk into huijbers/cloudwatch-alarm-styles
|
|
||
| // if this is a region-agnostic stack, we can't assume anything about stat.account | ||
| // and therefore we assume its a cross-account call | ||
| if (Token.isUnresolved(stackAccount)) { |
Contributor
There was a problem hiding this comment.
You might as well remove this if entirely.
otaviomacedo
approved these changes
Nov 17, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Render legacy style alarms even if the user explicitly passes in the `Aws.ACCOUNT_ID` token: we can compare these strings since we every call to `Aws.ACCOUNT_ID` is guaranteed to return the same tokenized string. Only switch to modern-style alarms if we cannot successfully determine that they are definitely equal. This simplifies one more case that would accidentally trigger new-style alarms, which some SNS notification consumers are not equipped to handle. Add a section to the README explaining the differences between old and new-style alarms, and that SNS consumers need to pay attention to the differences. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render legacy style alarms even if the user explicitly passes in the
Aws.ACCOUNT_IDtoken: we can compare these strings since we every callto
Aws.ACCOUNT_IDis guaranteed to return the same tokenized string.Only switch to modern-style alarms if we cannot successfully determine
that they are definitely equal.
This simplifies one more case that would accidentally trigger new-style
alarms, which some SNS notification consumers are not equipped to handle.
Add a section to the README explaining the differences between old and
new-style alarms, and that SNS consumers need to pay attention to the
differences.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license