Skip to content

chore(integ): clearly show versions being tested#17469

Merged
mergify[bot] merged 2 commits intomasterfrom
huijbers/print-regr-cli
Nov 11, 2021
Merged

chore(integ): clearly show versions being tested#17469
mergify[bot] merged 2 commits intomasterfrom
huijbers/print-regr-cli

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Nov 11, 2021

Three changes:

  • Clearly show all versions involved in regression tests (framework, CLI
    and tests).
  • Stop printing all extracted files, it's very distracting.
  • Also copy over the helper directory from previous tests. Otherwise,
    any backwards incompatible changes we make in the tests themselves
    are going to break the tests. Not an issue right now, but it might be in the future.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Three changes:

- Clearly show all versions involved in regression tests (framework, CLI
  and tests).
- Stop printing all extracted files, it's very distracting.
- Also copy over the `helper` directory from previous tests. Otherwise,
  any backwards incompatible changes we make in the tests themselves
  are going to break the tests.
@rix0rrr rix0rrr requested a review from a team November 11, 2021 14:38
@rix0rrr rix0rrr self-assigned this Nov 11, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 11, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 11, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e7919f9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0885394 into master Nov 11, 2021
@mergify mergify bot deleted the huijbers/print-regr-cli branch November 11, 2021 16:24
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Three changes:

- Clearly show all versions involved in regression tests (framework, CLI
  and tests).
- Stop printing all extracted files, it's very distracting.
- Also copy over the `helper` directory from previous tests. Otherwise,
  any backwards incompatible changes we make in the tests themselves
  are going to break the tests. Not an issue right now, but it might be in the future.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants