feat(aws-applicationautoscaling): Allow autoscaling with "M out of N" datapoints#17441
feat(aws-applicationautoscaling): Allow autoscaling with "M out of N" datapoints#17441mergify[bot] merged 6 commits intoaws:masterfrom
Conversation
|
|
|
@comcalvi Any way this could be merged in? There's not much to this change and it'd be nice to have this functionality. |
comcalvi
left a comment
There was a problem hiding this comment.
Looks great! A few minor changes and this will be ready to be merged.
packages/@aws-cdk/aws-applicationautoscaling/test/step-scaling-policy.test.ts
Show resolved
Hide resolved
|
@comcalvi Ok, I think this should be resolved now. |
There was a problem hiding this comment.
@stephenwiebe can you add the new property to the relevant section of the readme?
comcalvi
left a comment
There was a problem hiding this comment.
To fix the linter error, could you add the new property and brief of explanation of it to the README?
Pull request has been modified.
comcalvi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this to the readme 😄
Pull request has been modified.
|
@comcalvi What's the next step to get it merged in? I wasn't sure if I needed to merge the master branch back into mine, so I did that but it looks like it might have nullified your review. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… datapoints (aws#17441) This PR closes aws#17433. It adds a `datapointsToAlarm` property to the `StepScalingPolicy` construct which allows auto-scaling activities to trigger when only a portion of the data points in the evaluation periods are breaching. Motivation: Some metrics may have a certain amount of noise/randomness and in these cases it may make more sense to not require that all data points must be breaching for auto-scaling activity to trigger. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR closes #17433. It adds a
datapointsToAlarmproperty to theStepScalingPolicyconstruct which allows auto-scaling activities to trigger when only a portion of the data points in the evaluation periods are breaching.Motivation: Some metrics may have a certain amount of noise/randomness and in these cases it may make more sense to not require that all data points must be breaching for auto-scaling activity to trigger.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license