Skip to content

feat(stepfunctions-tasks): Support DynamoAttributeValue.listFromJsonPath#17376

Merged
mergify[bot] merged 12 commits intoaws:masterfrom
rogerchi:master
Nov 9, 2021
Merged

feat(stepfunctions-tasks): Support DynamoAttributeValue.listFromJsonPath#17376
mergify[bot] merged 12 commits intoaws:masterfrom
rogerchi:master

Conversation

@rogerchi
Copy link
Copy Markdown
Contributor

@rogerchi rogerchi commented Nov 6, 2021 •
edited
Loading

Add DynamoAttributeValue.listFromJsonPath(value: string) to allow specifying a list/array from the state input as a parameter in a DynamoDB PutItem or UpdateItem optimized integration in stepfunctions-tasks.

Closes #17375

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 6, 2021

@kaizencc kaizencc changed the title feat(aws-stepfunctions-tasks): Add DynamoAttributeValue.listFromJsonPath feat(stepfunctions-tasks): Add DynamoAttributeValue.listFromJsonPath Nov 8, 2021
@kaizencc kaizencc changed the title feat(stepfunctions-tasks): Add DynamoAttributeValue.listFromJsonPath feat(stepfunctions-tasks): Support DynamoAttributeValue.listFromJsonPath Nov 8, 2021
kaizencc
kaizencc previously requested changes Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerchi! Thanks for the feature! This looks good, with a small nit. I don't think we need to update the README for this one. Go ahead and take it out, and I will mark this pr-linter/exempt-readme to bypass the PR check.

Instead, can you provide a bit more detail in the PR description as to the motivation for this PR. That will become the commit message when we merge this PR.

@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 8, 2021
@mergify mergify bot dismissed kaizencc’s stale review November 9, 2021 00:08

Pull request has been modified.

@rogerchi
Copy link
Copy Markdown
Contributor Author

rogerchi commented Nov 9, 2021

Removed README.md changes and updated PR message

kaizencc
kaizencc previously approved these changes Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review November 9, 2021 16:17

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 9, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 93d81db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bc10e6f into aws:master Nov 9, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@rogerchi @TikiTDO
feat(stepfunctions-tasks): Support `DynamoAttributeValue.listFromJson…
7690b42 
…Path` (aws#17376)

Add `DynamoAttributeValue.listFromJsonPath(value: string)` to allow specifying a list/array from the state input as a parameter in a DynamoDB PutItem or UpdateItem optimized integration in stepfunctions-tasks.

Closes aws#17375 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

@kaizencc kaizencc

Labels

@aws-cdk/aws-stepfunctions-tasks pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(stepfunctions-tasks): add DynamoAttributeValue.listFromJsonPath()

3 participants

@rogerchi @aws-cdk-automation @kaizencc