feat(rds,secretsmanager): subnets and endpoint configuration for secret rotation#17363
feat(rds,secretsmanager): subnets and endpoint configuration for secret rotation#17363mergify[bot] merged 5 commits intoaws:masterfrom
Conversation
…et rotation Add options to configure vpc subnet placement and Secrets Manager API endpoint for the rotation Lambda function. This is required in some VPC configurations where the database is placed in subnets without internet connectivity. Closes aws#17265
|
|
| target: this, | ||
| excludeCharacters: DEFAULT_PASSWORD_EXCLUDE_CHARS, | ||
| ...options, | ||
| excludeCharacters: options.excludeCharacters ?? DEFAULT_PASSWORD_EXCLUDE_CHARS, |
There was a problem hiding this comment.
I actually like the old code more 😕 (it's very obvious in the old one that options.excludeCharacters will be taken into account, while you would have to look at the definition of RotationSingleUserOptions and SecretRotationProps to know that happens in the new code).
Can we revert this?
| }); | ||
| }); | ||
|
|
||
| test('addRotationSingleUser() with options', () => { |
There was a problem hiding this comment.
| test('addRotationSingleUser() with options', () => { | |
| test('addRotationSingleUser() with VPC Subnets', () => { |
There was a problem hiding this comment.
The other options (automaticallyAfter and excludeCharacters) are tested here too.
| }); | ||
| }); | ||
|
|
||
| test('addRotationSingleUser() with options', () => { |
There was a problem hiding this comment.
| test('addRotationSingleUser() with options', () => { | |
| test('addRotationSingleUser() with VPC Subnets', () => { |
There was a problem hiding this comment.
The other options (automaticallyAfter and excludeCharacters) are tested here too.
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…et rotation (#17363) Add options to configure vpc subnet placement and Secrets Manager API endpoint for the rotation Lambda function. This is required in some VPC configurations where the database is placed in subnets without internet connectivity. Closes #17265 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…et rotation (aws#17363) Add options to configure vpc subnet placement and Secrets Manager API endpoint for the rotation Lambda function. This is required in some VPC configurations where the database is placed in subnets without internet connectivity. Closes aws#17265 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add options to configure vpc subnet placement and Secrets Manager API
endpoint for the rotation Lambda function.
This is required in some VPC configurations where the database is placed
in subnets without internet connectivity.
Closes #17265
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license