feat(pipelines): support timeout in CodeBuildStep#17351
feat(pipelines): support timeout in CodeBuildStep#17351mergify[bot] merged 7 commits intoaws:masterfrom
Conversation
|
|
|
I don't think this build failure is my fault: |
But you could make it do that? |
Pull request has been modified.
|
Hi @rix0rrr: it seems you implemented what you asked? I can see this showing up in the merge. Anything else needed from me? |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Make sure we can set timeout for those long running tests.
There's one thing I didn't get. In `_codebuild-factory.ts/produceAction()` I expected that this line:
```
const projectOptions = mergeCodeBuildOptions(options.codeBuildDefaults, this.props.projectOptions);
```
would merge in the timeout if set. But it didn't do that. So that's why I pull the timeout in the later `codebuild.PipelineProject` explicitly via:
```
timeout: this.props.projectOptions?.timeout,
```
Not sure why I had to do that. I noticed that `options.codeBuildDefaults` didn't have the timeout field, perhaps that's why the merge didn't work, or perhaps I don't understand this merge, and what I did was right :-)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Make sure we can set timeout for those long running tests.
There's one thing I didn't get. In
_codebuild-factory.ts/produceAction()I expected that this line:would merge in the timeout if set. But it didn't do that. So that's why I pull the timeout in the later
codebuild.PipelineProjectexplicitly via:Not sure why I had to do that. I noticed that
options.codeBuildDefaultsdidn't have the timeout field, perhaps that's why the merge didn't work, or perhaps I don't understand this merge, and what I did was right :-)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license