Skip to content

fix(codecommit): notifyOnPullRequestMerged method has a typo in its name#17348

Merged
mergify[bot] merged 8 commits intoaws:masterfrom
clairemr:master
Nov 9, 2021
Merged

fix(codecommit): notifyOnPullRequestMerged method has a typo in its name#17348
mergify[bot] merged 8 commits intoaws:masterfrom
clairemr:master

Conversation

@clairemr
Copy link
Copy Markdown
Contributor

@clairemr clairemr commented Nov 5, 2021

The current method notifiyOnPullRequestMerged has a typo in the name.
This PR is to create a method called notifyOnPullRequestMerged with the same functionality,
minus the spelling mistake.

Marks notifiyOnPullRequestMerged as deprecated so as not to break existing code.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 5, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codecommit Related to AWS CodeCommit label Nov 5, 2021
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @clairemr!

A few small notes. If you could also edit the description of the PR, to explain what the purpose of this change is, that would be super helpful 🙂.

@skinny85 skinny85 changed the title fix(aws-codecommit): fix notifyOnPullRequestMerged method name fix(codecommit): notifyOnPullRequestMerged has a typo in its name Nov 5, 2021
@skinny85 skinny85 changed the title fix(codecommit): notifyOnPullRequestMerged has a typo in its name fix(codecommit): notifyOnPullRequestMerged method has a typo in its name Nov 5, 2021
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review November 9, 2021 00:15

Pull request has been modified.

@clairemr
Copy link
Copy Markdown
Contributor Author

clairemr commented Nov 9, 2021

Hi @skinny85,
I think I've made the required changes, let me know if there's anything else needed.

Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @clairemr!

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5b43fb5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cac5726 into aws:master Nov 9, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ame (aws#17348)

The current method `notifiyOnPullRequestMerged` has a typo in the name.
This PR is to create a method called `notifyOnPullRequestMerged` with the same functionality,
minus the spelling mistake. 

Marks `notifiyOnPullRequestMerged` as deprecated so as not to break existing code.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-codecommit Related to AWS CodeCommit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants