chore(cli): v2 python init templates have incorrect constructs version#17333
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 4, 2021
Merged
chore(cli): v2 python init templates have incorrect constructs version#17333mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
The init templates were modified as part of #17062. One change was for the 'app' and 'sample-app' templates to use 'requirements.txt' instead of 'setup.py'. In that conversion, a quirk of the `%constructsversion%` replacement was lost; that replacement inserts the version comparison `>=` itself, so having it in the requirements.txt results in a broken specifier. This was caught in the forward-merge to v2, where there are additional tests verfying the constructs versions.
|
|
otaviomacedo
approved these changes
Nov 4, 2021
corymhall
approved these changes
Nov 4, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
aws#17333) The init templates were modified as part of aws#17062. One change was for the 'app' and 'sample-app' templates to use 'requirements.txt' instead of 'setup.py'. In that conversion, a quirk of the `%constructsversion%` replacement was lost; that replacement inserts the version comparison `>=` itself, so having it in the requirements.txt results in a broken specifier. This was caught in the forward-merge to v2, where there are additional tests verfying the constructs versions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init templates were modified as part of #17062. One change was for the 'app'
and 'sample-app' templates to use 'requirements.txt' instead of 'setup.py'. In
that conversion, a quirk of the
%constructsversion%replacement was lost; thatreplacement inserts the version comparison
>=itself, so having it in therequirements.txt results in a broken specifier.
This was caught in the forward-merge to v2, where there are additional tests
verfying the constructs versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license