Skip to content

fix(aws-ecs): check for invalid capacityProviderName#17291

Merged
mergify[bot] merged 6 commits intoaws:masterfrom
neilkuan:fix/pre-check-capacity-provider-name
Nov 20, 2021
Merged

fix(aws-ecs): check for invalid capacityProviderName#17291
mergify[bot] merged 6 commits intoaws:masterfrom
neilkuan:fix/pre-check-capacity-provider-name

Conversation

@neilkuan
Copy link
Copy Markdown
Contributor

@neilkuan neilkuan commented Nov 3, 2021 •
edited
Loading

fix(aws-ecs): add precheck name of capacity provider when specify it.
chore(aws-ecs): update capacityProviderName Description

close #17321

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@neilkuan
fix(aws-ecs): add precheck name of capacity provider when specify it.
666209e 
chore(aws-ecs): update capacityProviderName Description
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 3, 2021

@neilkuan neilkuan changed the title fix(aws-ecs): add precheck name of capacity provider when specify it. fix(ecs): add precheck name of capacity provider when specify it. Nov 3, 2021
@neilkuan neilkuan changed the title fix(ecs): add precheck name of capacity provider when specify it. fix(aws-ecs): add pre-check name of capacity provider when specify it. Nov 3, 2021
@neilkuan
Copy link
Copy Markdown
Contributor Author

neilkuan commented Nov 3, 2021

Hi @peterwoodworth, do you have a free to take a look this PR, thank you. :)

@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Nov 3, 2021

Thanks for the contribution @neilkuan! is there any original issue which this is meant to close? And if not, could you create one to describe the issue that needs to be fixed? Thanks

@peterwoodworth peterwoodworth changed the title fix(aws-ecs): add pre-check name of capacity provider when specify it. fix(aws-ecs): add pre-check name of capacity provider when specify it Nov 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Nov 3, 2021
@neilkuan
Copy link
Copy Markdown
Contributor Author

neilkuan commented Nov 4, 2021

thank @peterwoodworth , already create the issue #17321.

@peterwoodworth peterwoodworth changed the title fix(aws-ecs): add pre-check name of capacity provider when specify it feat(aws-ecs): check for invalid capacityProviderName Nov 4, 2021
@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Nov 4, 2021

I think this looks good - I don't think this would be a breaking change. @madeline-k should verify though

@neilkuan
Copy link
Copy Markdown
Contributor Author

neilkuan commented Nov 7, 2021

Hi @madeline-k , do you have a free to take a look this PR, thank you. :)

@neilkuan
Copy link
Copy Markdown
Contributor Author

neilkuan commented Nov 9, 2021

Hi @peterwoodworth, actually this PR adds a pre-check in CDK to avoid possible deployment failure and does not add any new features. It doesn't make sense to update the README to pass the lint. Let's classify it as chore or fix. wdyt?

pahud
pahud previously requested changes Nov 9, 2021
View reviewed changes
@mergify mergify bot dismissed pahud’s stale review November 9, 2021 03:32

Pull request has been modified.

pahud
pahud reviewed Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pahud pahud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterwoodworth peterwoodworth added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 9, 2021
@peterwoodworth peterwoodworth changed the title feat(aws-ecs): check for invalid capacityProviderName fix(aws-ecs): check for invalid capacityProviderName Nov 9, 2021
@pahud
Copy link
Copy Markdown
Contributor

pahud commented Nov 9, 2021

Hi @madeline-k can you take a look please?

@upparekh
Copy link
Copy Markdown
Contributor

upparekh commented Nov 19, 2021

Hi @neilkuan , can you please resolve the conflicts before we can merge this PR?

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 20, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 01512c4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6e2fde4 into aws:master Nov 20, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@neilkuan neilkuan deleted the fix/pre-check-capacity-provider-name branch November 22, 2021 04:48
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@neilkuan @TikiTDO
fix(aws-ecs): check for invalid capacityProviderName (aws#17291)
a16173e 
fix(aws-ecs): add precheck name of capacity provider when specify it.
chore(aws-ecs): update capacityProviderName Description


close aws#17321
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pahud pahud pahud left review comments

+1 more reviewer

@upparekh upparekh upparekh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@madeline-k madeline-k

Labels

@aws-cdk/aws-ecs Related to Amazon Elastic Container pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-ecs): in case you define the name of ecs capacity provider start with aws, ecs or fargate will create fail.

6 participants

@neilkuan @peterwoodworth @pahud @upparekh @aws-cdk-automation @madeline-k