docs(lambda-destination): add onFailure destination example and be explicit about the type of SQS queue that can be used#17283
Merged
mergify[bot] merged 41 commits intoaws:masterfrom Dec 18, 2021
Conversation
|
|
nija-at
previously requested changes
Nov 16, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Thanks for the docs update @RichardWatkins1.
Couple of comments below.
|
|
||
| * Lambda function | ||
| * SQS queue | ||
| * Standard SQS queue |
Contributor
There was a problem hiding this comment.
FIFO queues are supported for successful invocations, right?
Contributor
Author
There was a problem hiding this comment.
Yes sorry you're right will update 👍
| }) | ||
| ``` | ||
|
|
||
| *Only standard SQS queues are supported for failure destinations, FIFO queues are not supported. |
Contributor
There was a problem hiding this comment.
Can you move this statement to line 20?
…ithub.com/RichardWatkins1/aws-cdk into chore-lambda-destinations-add-dlq-example
Pull request has been modified.
…ithub.com/RichardWatkins1/aws-cdk into chore-lambda-destinations-add-dlq-example
…ithub.com/RichardWatkins1/aws-cdk into chore-lambda-destinations-add-dlq-example
kaizencc
reviewed
Dec 14, 2021
Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>
kaizencc
approved these changes
Dec 18, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
closes #13793