feat(iot): allow setting description and enabled of TopicRule#17225
feat(iot): allow setting description and enabled of TopicRule#17225mergify[bot] merged 6 commits intoaws:masterfrom
description and enabled of TopicRule#17225Conversation
1. add properties `description` and `enabled` 2. add tests
|
|
skinny85
left a comment
There was a problem hiding this comment.
Looks great @yamatatsu! One small comment that will make your life easier I'm pretty sure 🙂.
| actions: Lazy.any({ produce: () => this.actions }), | ||
| awsIotSqlVersion: sqlConfig.awsIotSqlVersion, | ||
| description: props.description, | ||
| ruleDisabled: !(props.enabled ?? true), |
There was a problem hiding this comment.
Let's leave this as undefined if enabled is undefined (I assume the default in CloudFormation is false for the RuleDisabled property):
| ruleDisabled: !(props.enabled ?? true), | |
| ruleDisabled: props.enabled === undefined ? undefined : !props.enabled, |
This way, there will be no changes in the existing templates.
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| topicRule.addAction(new actions.LambdaFunctionAction(func)) | ||
| ``` | ||
|
|
||
| If you wanna make the topic rule disable, add property `enabled: false` as following: |
There was a problem hiding this comment.
"If you wanna make the topic rule disable" -> "If you want to make the topic rule disasbled"
…s#17225) I'm trying to implement aws-iot L2 Constructs. This PR is one of steps after following PR: - aws#16681 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I'm trying to implement aws-iot L2 Constructs.
This PR is one of steps after following PR:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license