feat(eks): install helm chart from asset#17217
Merged
mergify[bot] merged 46 commits intoaws:masterfrom Dec 16, 2021
cmckni3:helm-asset
Merged
feat(eks): install helm chart from asset#17217mergify[bot] merged 46 commits intoaws:masterfrom cmckni3:helm-asset
mergify[bot] merged 46 commits intoaws:masterfrom
cmckni3:helm-asset
Conversation
* Ensure chart and chartAsset are validated by the construct
|
|
cmckni3
commented
Oct 28, 2021
cmckni3
commented
Oct 28, 2021
cmckni3
commented
Oct 28, 2021
cmckni3
commented
Oct 28, 2021
Co-authored-by: Otavio Macedo <otaviomacedo@protonmail.com>
Contributor
Author
|
@iliapolo @otaviomacedo ready for review again. |
iliapolo
previously approved these changes
Dec 16, 2021
Pull request has been modified.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
approved these changes
Dec 16, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Adding on to the work @plumdog started on aws#13496 and @pradoz in aws#15899. Implemented the @iliapolo's [suggested changes](https://github.com/aws/aws-cdk/pull/15899/files#r683431181) Related to aws#9273 ### Use Case To be able to use private helm charts without needing a private chart repository. ### Proposed Solution [Allow helm charts](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-eks.HelmChart.html) to be an asset by introducing the property `chartAsset`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding on to the work @plumdog started on #13496 and @pradoz in #15899. Implemented the @iliapolo's suggested changes
Related to #9273
Use Case
To be able to use private helm charts without needing a private chart repository.
Proposed Solution
Allow helm charts to be an asset by introducing the property
chartAsset.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license