chore: disable 'rosetta strict' for all packages#17211
Merged
mergify[bot] merged 2 commits intomasterfrom Oct 28, 2021
Merged
Conversation
Currently, `strict` mode in Rosetta will fail the build in the pipeline without failing the build in a PR review. This causes unpredictable stoppages in our pipeline that we cannot afford, so we're disabling the feature for now. Strict mode will be re-enabled as soon as we are able to add Rosetta checks to PR reviews.
|
|
njlynch
approved these changes
Oct 28, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Currently, `strict` mode in Rosetta will fail the build in the pipeline without failing the build in a PR review. This causes unpredictable stoppages in our pipeline that we cannot afford, so we're disabling the feature for now. Strict mode will be re-enabled as soon as we are able to add Rosetta checks to PR reviews. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
strictmode in Rosetta will fail the build in the pipelinewithout failing the build in a PR review.
This causes unpredictable stoppages in our pipeline that we cannot
afford, so we're disabling the feature for now.
Strict mode will be re-enabled as soon as we are able to add Rosetta
checks to PR reviews.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license