chore: revert activate 'rosetta infuse' feature#17207
Merged
mergify[bot] merged 1 commit intomasterfrom Oct 28, 2021
Merged
Conversation
This reverts commit 5cee43e.
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
nija-at
approved these changes
Oct 28, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The examples we copy into docblocks may contain block comments themselves.
However, the docblock renderer does not escape the docblock *closing* text, so the doc block gets terminated early and compiling fails:
```java
/**
* Initialization props for the `NestedStack` construct.
* <p>
* Example:
* <p>
* <blockquote><pre>{@code
* // Example automatically generated. See aws/jsii#826
* import software.amazon.awscdk.core.App;
* import software.amazon.awscdk.core.CfnOutput;
* import software.amazon.awscdk.core.NestedStack;
* import lib.RestApi;
* import lib.Stage;
* /**
* * This file showcases how to split up a RestApi's Resources and Methods across nested stacks.
* *
* * The root stack 'RootStack' first defines a RestApi.
* * Two nested stacks BooksStack and PetsStack, create corresponding Resources '/books' and '/pets'.
* * They are then deployed to a 'prod' Stage via a third nested stack - DeployStack.
* *
* * To verify this worked, go to the APIGateway
* */ <------------ OOOPS!
* public class RootStack extends Stack {
* public RootStack(Construct scope) {
* super(scope, "integ-restapi-import-RootStack");
* RestApi restApi = RestApi.Builder.cre
```
Revert this until we can address the quoting issue.
Reverts aws#17191
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples we copy into docblocks may contain block comments themselves.
However, the docblock renderer does not escape the docblock closing text, so the doc block gets terminated early and compiling fails:
Revert this until we can address the quoting issue.
Reverts #17191