Skip to content

feat(codebuild): add fromEcrRepository to LinuxGpuBuildImage#17170

Merged
mergify[bot] merged 17 commits intoaws:masterfrom
iRoachie:linux-gpu-ecr
Oct 28, 2021
Merged

feat(codebuild): add fromEcrRepository to LinuxGpuBuildImage#17170
mergify[bot] merged 17 commits intoaws:masterfrom
iRoachie:linux-gpu-ecr

Conversation

@iRoachie
Copy link
Copy Markdown
Contributor

Resolves #16500


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @iRoachie! A few small comments.

iRoachie and others added 2 commits October 26, 2021 19:18
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
…t.ts

Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review October 26, 2021 19:18

Pull request has been modified.

@iRoachie
Copy link
Copy Markdown
Contributor Author

@skinny85 Addressed the comments

Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @iRoachie, I actually realized we need a small change here. Shouldn't be too bad though I think, just requires one more test.

…t.ts

Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review October 27, 2021 02:50

Pull request has been modified.

@iRoachie
Copy link
Copy Markdown
Contributor Author

@skinny85 that should be it

Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome contribution @iRoachie!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 52bc826
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7585680 into aws:master Oct 28, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iRoachie iRoachie deleted the linux-gpu-ecr branch October 28, 2021 10:35
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Resolves aws#16500


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-codebuild Related to AWS CodeBuild

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(codebuild): allow LinuxGpuBuildImage to directly reference an image from any ECR repository

3 participants