fix(pipelines): additionalInputs fails for deep directory#17074
Merged
mergify[bot] merged 1 commit intomasterfrom Oct 20, 2021
Merged
fix(pipelines): additionalInputs fails for deep directory#17074mergify[bot] merged 1 commit intomasterfrom
additionalInputs fails for deep directory#17074mergify[bot] merged 1 commit intomasterfrom
Conversation
If the directory is nested deeper than one level underneath `.` or `..`, the wrong directory gets created. Also add in protection against the directory already existing, in which case the same behavior would happen. Fixes #16936.
otaviomacedo
approved these changes
Oct 20, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hi @rix0rrr, This PR looks like it has introduced a failure on my current pipeline. This now stops the build with the following error: Am I doing something wrong? Or is this a regression? |
|
Experiencing the same issue as @fab-mindflow. Could you please advice whether the behaviour of additionalInputs has changed? |
Contributor
Author
|
This was a regression that was fixed in #17279 |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
If the directory is nested deeper than one level underneath `.` or `..`, the wrong directory gets created. Also add in protection against the directory already existing, in which case the same behavior would happen. Fixes aws#16936. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the directory is nested deeper than one level underneath
.or..,the wrong directory gets created.
Also add in protection against the directory already existing, in which
case the same behavior would happen.
Fixes #16936.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license