Skip to content

docs(appsync): make examples compile#17045

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
kaizencc:compile/appsync
Oct 19, 2021
Merged

docs(appsync): make examples compile#17045
mergify[bot] merged 3 commits intoaws:masterfrom
kaizencc:compile/appsync

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Oct 18, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 18, 2021
@kaizencc kaizencc requested a review from rix0rrr October 18, 2021 21:19
@kaizencc kaizencc requested a review from rix0rrr October 19, 2021 15:46
@@ -537,48 +550,38 @@ Above we see a schema that allows for generating paginated responses. For exampl
we can query `allFilms(first: 100)` since `FilmConnection` acts as an intermediary
for holding `FilmEdges` we can write a resolver to return the first 100 films.

Copy link
Copy Markdown
Contributor Author

@kaizencc kaizencc Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking this location for convenience -- PR comments are about the example below (too long to block comment).


> This method allows for reusability and modularity, ideal for larger projects.
For example, imagine moving all Object Type definition outside the stack.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR comments are also about this example.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c695f09
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f681f29 into aws:master Oct 19, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc deleted the compile/appsync branch October 19, 2021 17:48
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants