Skip to content

chore(pipelines): deprecate legacy API#17034

Merged
mergify[bot] merged 1 commit intomasterfrom
huijbers/deprecate-old-pipelines-api
Oct 18, 2021
Merged

chore(pipelines): deprecate legacy API#17034
mergify[bot] merged 1 commit intomasterfrom
huijbers/deprecate-old-pipelines-api

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Oct 18, 2021

The presence of the legacy API for CDK Pipelines confuses people who
didn't read the README or the blog post, but go from a copy/pasted
example they found on the internet and then proceed to explore the API.

Clearly deprecate the legacy classes to avoid confusion.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The presence of the legacy API for CDK Pipelines confuses people who
didn't read the README or the blog post, but go from a copy/pasted
example they found on the internet and then proceed to explore the API.

Clearly deprecate the legacy classes to avoid confusion.
@rix0rrr rix0rrr requested a review from a team October 18, 2021 08:16
@rix0rrr rix0rrr self-assigned this Oct 18, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Oct 18, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 18, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9e94a43
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 999e999 into master Oct 18, 2021
@mergify mergify bot deleted the huijbers/deprecate-old-pipelines-api branch October 18, 2021 09:10
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
The presence of the legacy API for CDK Pipelines confuses people who
didn't read the README or the blog post, but go from a copy/pasted
example they found on the internet and then proceed to explore the API.

Clearly deprecate the legacy classes to avoid confusion.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants