Skip to content

chore(iam): reorganize imports to fix circular dependency issue#16932

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
comcalvi:iam-import-fix
Oct 13, 2021
Merged

chore(iam): reorganize imports to fix circular dependency issue#16932
mergify[bot] merged 2 commits intoaws:masterfrom
comcalvi:iam-import-fix

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

To recreate this issue, create a blank CDK App and add a single Lambda Function to it. Synthesis will fail with the message "Class extends value undefined is not a constructor or null". This is caused by AnyPrincipal being imported from './' and other classes from the same file as AnyPrincipal (principals.ts) being imported from './principals'.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Oct 13, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 13, 2021
@comcalvi comcalvi requested a review from skinny85 October 13, 2021 00:25
@skinny85 skinny85 changed the title fix(aws-iam): Reorganize Imports to Fix Circular Dependency Issue At Synth Time choe(iam): reorganize imports to fix circular dependency issue Oct 13, 2021
@skinny85 skinny85 changed the title choe(iam): reorganize imports to fix circular dependency issue chore(iam): reorganize imports to fix circular dependency issue Oct 13, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e207fd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 831638e into aws:master Oct 13, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…16932)

To recreate this issue, create a blank CDK App and add a single Lambda Function to it. Synthesis will fail with the message "Class extends value undefined is not a constructor or null". This is caused by `AnyPrincipal` being imported from `'./'` and other classes from the same file as `AnyPrincipal` (`principals.ts`) being imported from `'./principals'`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants