docs(appmesh): make examples compile#16926
docs(appmesh): make examples compile#16926mergify[bot] merged 6 commits intoaws:masterfrom kaizencc:appmesh/compile
Conversation
|
|
|
Thanks @kaizen3031593 for submitting the PR! I will review this within 2 business days. |
|
@kaizen3031593 should we switch the Rosetta mode to strict, to make sure future edits to the ReadMe keep compiling? |
rix0rrr
left a comment
There was a problem hiding this comment.
Looks good, I'm happy with this. Thanks.
Adding the do-not-merge label to give @Seiya6329 a chance to review as well. @Seiya6329, if you agree with the change just remove the do-not-merge label to have this be merged in.
@skinny85 we're definitely going to do that. Haven't evaluated that well enough yet to figure out when we can do it, but it's in the plans.
|
@rix0rrr - Everything looks good as well. I removed the label as instructed. @kaizen3031593 - Thanks again for updating the doc! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license