fix(aws-servicecatalog): Allow users to create multiple product versions from assets. #16914
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Oct 12, 2021
Merged
fix(aws-servicecatalog): Allow users to create multiple product versions from assets. #16914mergify[bot] merged 3 commits intoaws:masterfrom
mergify[bot] merged 3 commits intoaws:masterfrom
Conversation
…ons from assets This small PR should fix an issue brought up that we used a static `Template` as the resource name for assets which causes a collision if you have multiple versions. The correct configuration should be that the asset name is unique for each unique template file uploaded for a product version. Fixes: aws#16892
|
|
Contributor
Author
|
@skinny85 sorry it's been a while, not sure if you get auto assigned back to this eventually. I think this fix should be sufficient. |
skinny85
approved these changes
Oct 12, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ons from assets. (aws#16914) This small PR should fix an issue brought up that we used a static `Template` as the resource name for assets which causes a collision if you have multiple versions. The correct configuration should be that the asset name is unique for each unique template file uploaded for a product version. Fixes: aws#16892 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR should fix an issue brought up that we used a static
Templateas the resourcename for assets which causes a collision if you have multiple versions. The correct configuration
should be that the asset name is unique for each unique template file uploaded for a product version.
Fixes: #16892
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license