docs(ecs): make examples compile#16912
docs(ecs): make examples compile#16912mergify[bot] merged 8 commits intoaws:masterfrom kaizencc:ecs/compile
Conversation
|
|
| }); | ||
| ``` | ||
|
|
||
| ### Generic Log Driver |
There was a problem hiding this comment.
So GenericLogDriver.ts is not exported in index.ts. Relevant PR. Originally I thought, why not just export it and well, it causes a circular dependency (gives error: Class extends value undefined is not a constructor or null). I have no idea why. In fact, it doesn't look like GenericLogDriver or GenericLogDriverProps (the only two classes in the file) are referenced anywhere in the CDK. The file itself isn't even tested. Maybe it's safe to delete the file, but then again, how is there a circular dependency if it is not referenced anywhere?
This is all spooky to me so I did not end up touching it at all. As it stands, GenericLogDriver is not exposed therefore it shouldn't be referenced in the README.
There was a problem hiding this comment.
I think it's probably useful to have a GenericLogDriver -- we should strive to have some "escape hatch" style class everywhere, so that users can roll their own if ECS tomorrow rolls out a new feature and we haven't implemented it yet.
Let's have a look-see at what's going on here.
|
Oh I know. This is the issue in import { LogDriver, LogDriverConfig } from '../index';It reads it from the main Basically import from an import { LogDriver, LogDriverConfig } from './log-driver'; |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license