Skip to content

feat(apigatewayv2-authorizers): http api - allow multiple user pool clients per HttpUserPoolAuthorizer #16903

Merged
mergify[bot] merged 5 commits intoaws:masterfrom
tmokmss:allow_multiple_user_pool_clients
Nov 6, 2021
Merged

feat(apigatewayv2-authorizers): http api - allow multiple user pool clients per HttpUserPoolAuthorizer #16903
mergify[bot] merged 5 commits intoaws:masterfrom
tmokmss:allow_multiple_user_pool_clients

Conversation

@tmokmss
Copy link
Copy Markdown
Contributor

@tmokmss tmokmss commented Oct 11, 2021 •
edited by nija-at
Loading

closes #15431

BREAKING CHANGE: userPoolClient property in UserPoolAuthorizerProps
is now renamed to userPoolClients.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Oct 11, 2021

@peterwoodworth peterwoodworth changed the title fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2-authorizers Related to aws-apigatewayv2-authorizers package label Oct 21, 2021
@nija-at nija-at changed the title fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer feat(apigatewayv2-authorizers): http api - allow multiple user pools for HttpUserPoolAuthorizer Nov 5, 2021
nija-at
nija-at previously requested changes Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you add a new test case that adds multiple user pools and that verify that they show up in the Audience field?

@mergify mergify bot dismissed nija-at’s stale review November 6, 2021 01:02

Pull request has been modified.

@tmokmss
Copy link
Copy Markdown
Contributor Author

tmokmss commented Nov 6, 2021 •
edited
Loading

Hi @nija-at, thanks for the review! I added a test for that.
Also please be aware that this PR does NOT add support for multiple user pools, but multiple user pool clients. CFn only allows one user pool per Jwt authorizer. So I think this PR title is a bit misleading.

@nija-at nija-at changed the title feat(apigatewayv2-authorizers): http api - allow multiple user pools for HttpUserPoolAuthorizer feat(apigatewayv2-authorizers): http api - allow multiple user pool clients per HttpUserPoolAuthorizer Nov 6, 2021
@nija-at
Copy link
Copy Markdown
Contributor

nija-at commented Nov 6, 2021

Hi @nija-at, thanks for the review! I added a test for that. Also please be aware that this PR does NOT add support for multiple user pools, but multiple user pool clients. CFn only allows one user pool per Jwt authorizer. So I think this PR title is a bit misleading.

Ah, thanks for the clarification! I've updated the title.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 6, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 55fb0d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 747eb7c into aws:master Nov 6, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tmokmss tmokmss deleted the allow_multiple_user_pool_clients branch November 7, 2021 04:01
iliapolo pushed a commit that referenced this pull request Nov 7, 2021
@tmokmss @iliapolo
feat(apigatewayv2-authorizers): http api - allow multiple user pool c…
882e385 
…lients per HttpUserPoolAuthorizer (#16903)

closes #15431

BREAKING CHANGE: `userPoolClient` property in `UserPoolAuthorizerProps`
is now renamed to `userPoolClients`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@tmokmss @TikiTDO
feat(apigatewayv2-authorizers): http api - allow multiple user pool c…
2661129 
…lients per HttpUserPoolAuthorizer (aws#16903)

closes aws#15431

BREAKING CHANGE: `userPoolClient` property in `UserPoolAuthorizerProps`
is now renamed to `userPoolClients`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nija-at nija-at nija-at approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

@aws-cdk/aws-apigatewayv2-authorizers Related to aws-apigatewayv2-authorizers package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-apigatewayv2-authorizers): HttpUserPoolAuthorizer constructor should take and array of user pool client ids

3 participants

@tmokmss @nija-at @aws-cdk-automation