docs(aws-s3): Clarify update is required before setting autoDeleteObjects to false#16828
Merged
mergify[bot] merged 1 commit intomasterfrom Oct 6, 2021
Merged
Conversation
|
|
peterwoodworth
approved these changes
Oct 6, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…deploy" step. (#16857) ## Summary This PR is a continuation of #16828 (review) We want to make sure users know to deploy with the latest CDK version before toggling the `autoDeleteObjects` prop to `false`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
…jects` to `false` (#16828) ## Summary This PR: - Updates the documentation of the `aws-s3/Bucket`'s `autoDeleteObjects` prop to clarify that a user must first deploy with the latest CDK package before updating `autoDeleteObjects`'s value to `false` (to prevent the bucket from being emptied). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
…deploy" step. (#16857) ## Summary This PR is a continuation of #16828 (review) We want to make sure users know to deploy with the latest CDK version before toggling the `autoDeleteObjects` prop to `false`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…jects` to `false` (aws#16828) ## Summary This PR: - Updates the documentation of the `aws-s3/Bucket`'s `autoDeleteObjects` prop to clarify that a user must first deploy with the latest CDK package before updating `autoDeleteObjects`'s value to `false` (to prevent the bucket from being emptied). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…deploy" step. (aws#16857) ## Summary This PR is a continuation of aws#16828 (review) We want to make sure users know to deploy with the latest CDK version before toggling the `autoDeleteObjects` prop to `false`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
aws-s3/Bucket'sautoDeleteObjectsprop to clarify that a user must first deploy with the latest CDK package before updatingautoDeleteObjects's value tofalse(to prevent the bucket from being emptied).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license