feat(stepfunctions-tasks): add enableNetworkIsolation property to SageMakerCreateTrainingJobProps #16792
Conversation
|
|
enableNetworkIsolation property to SageMakerCreateTrainingJobProps
There was a problem hiding this comment.
The code looks great! In addition to the doc comment, can you update the README? I think it will be valuable to provide a sentence or two under the 'Sagemaker' headline that explains that AWS Marketplace resources require enableNetworkIsolation=true, plus a link to a doc.
Can you also update the PR blurb to describe the implementation (without the other stuff). It will be part of the commit message when the PR is merged so people can use it for reference.
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker/create-training-job.ts
Outdated
Show resolved
Hide resolved
|
Pull request has been modified.
4f3cb8f to
a263562
Compare
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
|
@kaizen3031593 |
kaizencc
left a comment
There was a problem hiding this comment.
Great job @TakaakiFuruse! This looks awesome. Thanks for the contribution!
Pull request has been modified.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…SageMakerCreateTrainingJobProps` (aws#16792) Closes aws#16779. This PR adds an option of `EnableNetworkIsolation` to `SageMakerCreateTrainingJob` class and enables a user to use AWS Marketplace. [Doc](https://docs.aws.amazon.com/sagemaker/latest/dg/mkt-algo-model-internet-free.html) says a user must turn the option to True when they attempt to use a machine learning model from AWS Marketplace. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #16779.
This PR adds an option of
EnableNetworkIsolationtoSageMakerCreateTrainingJobclass and enables a user to use AWS Marketplace.Doc says a user must turn the option to True when they attempt to use a machine learning model from AWS Marketplace.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license