feat(stepfunctions-tasks): AWS SDK service integrations#16746
Merged
mergify[bot] merged 17 commits intoaws:masterfrom Oct 8, 2021
Merged
feat(stepfunctions-tasks): AWS SDK service integrations#16746mergify[bot] merged 17 commits intoaws:masterfrom
mergify[bot] merged 17 commits intoaws:masterfrom
Conversation
|
|
Contributor
Author
2 tasks
RomainMuller
reviewed
Oct 6, 2021
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Show resolved
Hide resolved
RomainMuller
reviewed
Oct 6, 2021
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Outdated
Show resolved
Hide resolved
kaizencc
previously requested changes
Oct 7, 2021
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
This looks awesome! I have a few thoughts on documentation and am wondering why iamResources: ['*'] is the prevailing example throughout.
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * Properties for CallAwsService Task | ||
| */ | ||
| export interface CallAwsServiceProps extends sfn.TaskStateBaseProps { |
Contributor
There was a problem hiding this comment.
Is it possible for the documentation for these properties to be more robust in general? As someone without a ton of context for how to use this feature, I don't really gain much from the current documentation here.
Contributor
|
I'll let @kaizen3031593 have the last word on this PR. At this stage, it looks functionally good to me 👍🏻 |
jogold
commented
Oct 8, 2021
kaizencc
approved these changes
Oct 8, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
Add support for Step Functions' AWS SDK integrations to call any of the over two hundred AWS services directly from a state machine. See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/ Closes #16780 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Add support for Step Functions' AWS SDK integrations to call any of the over two hundred AWS services directly from a state machine. See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/ Closes aws#16780 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Step Functions' AWS SDK integrations to call
any of the over two hundred AWS services directly from a state
machine.
See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/
Closes #16780
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license