feat(appsync): Lambda Authorizer for AppSync GraphqlApi#16743
feat(appsync): Lambda Authorizer for AppSync GraphqlApi#16743mergify[bot] merged 10 commits intoaws:masterfrom kaizencc:appsync-lambda-auth
Conversation
|
|
| * | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appsync-graphqlapi-lambdaauthorizerconfig.html | ||
| */ | ||
| readonly functionArn: string; |
There was a problem hiding this comment.
This is most similar to what CFN wants, which is an authorizerUri. However, I feel like it is a CDK pattern to ask for readonly handler: lambda.IFunction instead and then generate the ARN under the hood. Wanted to bring it up to make sure a second pair of eyes looks at this decision.
There was a problem hiding this comment.
Yes, it's even in the design guidelines:
Use strong types (and specifically, construct interfaces) instead of physical attributes when referencing other resources. For example, instead of keyArn, use kms.IKey [awslint:props-no-arn-refs].
There was a problem hiding this comment.
Ah I see. I'll reread the design guidelines and change this up to be IFunction.
There was a problem hiding this comment.
@otaviomacedo, I made the change, so this should be ready for primetime whenever you have a chance.
|
I have successfully tested the code via symlink and confirmed that it works using this example. I can modify that code into an integration test if anyone thinks it is necessary. |
| * | ||
| * @default - no regex filter will be applied. | ||
| */ | ||
| readonly validationRegex?: string; |
There was a problem hiding this comment.
can we also accept RegEx here? (and convert to .source underneath, checking what to do with flags)
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds the relatively new [Lambda Authorizer for GraphqlApi](https://aws.amazon.com/blogs/mobile/appsync-lambda-auth/). Closes: #16380. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds the relatively new [Lambda Authorizer for GraphqlApi](https://aws.amazon.com/blogs/mobile/appsync-lambda-auth/). Closes: aws#16380. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds the relatively new Lambda Authorizer for GraphqlApi.
Closes: #16380.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license