fix: set ROSETTA_MAX_WORKER_COUNT in pack.sh#16738
Merged
mergify[bot] merged 1 commit intomasterfrom Sep 30, 2021
Merged
Conversation
Remove global environment variables that are set in buildspec.yml files as these interfere with more granular settings set in pack.sh, and instead move all settings there. The max heap size (8G) configured in pack.sh was overridden by the one set in buildspec.yml because the last time the option is passed wins, and pack.sh _prepends_ to `NODE_OPTIONS`.
|
|
njlynch
approved these changes
Sep 30, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
Remove global environment variables that are set in buildspec.yml files as these interfere with more granular settings set in pack.sh, and instead move all settings there. The max heap size (8G) configured in pack.sh was overridden by the one set in buildspec.yml because the last time the option is passed wins, and pack.sh _prepends_ to `NODE_OPTIONS`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Remove global environment variables that are set in buildspec.yml files as these interfere with more granular settings set in pack.sh, and instead move all settings there. The max heap size (8G) configured in pack.sh was overridden by the one set in buildspec.yml because the last time the option is passed wins, and pack.sh _prepends_ to `NODE_OPTIONS`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove global environment variables that are set in buildspec.yml files
as these interfere with more granular settings set in pack.sh, and
instead move all settings there.
The max heap size (8G) configured in pack.sh was overridden by the one
set in buildspec.yml because the last time the option is passed wins,
and pack.sh prepends to
NODE_OPTIONS.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license