feat(core): subtract Durations#16734
Conversation
Add a `.subtract()` method to `Duration`. Deprecate `.plus()` in favor of `.add()`, feels like a better naming. Closes aws#16535
|
|
rix0rrr
left a comment
There was a problem hiding this comment.
Deprecate .plus() in favor of .add(): it feels like a better naming.
I don't agree. What reads better:
- 3 hours plus 30 minutes
- 3 hours add 30 minutes
Not to mention that add sounds mutable, whereas plus definitely doesn't:
const x = Duration.hours(3);
x.add(Duration.minutes(30)); // From the name, I can't tell if this mutates x
x.plus(Duration.minutes(30)); // From the name, I can definitely tell this *doesn't* mutate x
Why not rename subtract -> minus ?
Good point. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add a `.minus()` method to `Duration`. Closes aws#16535 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a
.minus()method toDuration.Closes #16535
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license