chore: (revert) chore: move modules to assertions (#16671)#16727
Merged
mergify[bot] merged 3 commits intomasterfrom Sep 30, 2021
Merged
chore: (revert) chore: move modules to assertions (#16671)#16727mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
This reverts commit be6aa2e. This commit, coupled with the newStyleSynthesis flag (enabled by default on the v2 branch) do not play nicely together. This is due to the default resources present in every template (Parameter and Rule for checking bootstrap version). The `templateMatches` usage introduced in the original PR does not filter out these default inclusions, leading to most every of those tests to fail. Rather than block the forward merge on trying to come up with a clever solution, temporarily reverting.
|
|
rix0rrr
approved these changes
Sep 30, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Sep 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
#16740) This reverts commit 5e452f8. Similar to #16727, reverting the move to assertions until the correct API to use for the combination of `matchTemplate` and `newStyleSynthesis` can be defined. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
added a commit
that referenced
this pull request
Oct 11, 2021
This reverts commit be6aa2e. This commit, coupled with the newStyleSynthesis flag (enabled by default on the v2 branch) do not play nicely together. This is due to the default resources present in every template (Parameter and Rule for checking bootstrap version). The `templateMatches` usage introduced in the original PR does not filter out these default inclusions, leading to most every of those tests to fail. Rather than block the forward merge on trying to come up with a clever solution, temporarily reverting. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
added a commit
that referenced
this pull request
Oct 11, 2021
#16740) This reverts commit 5e452f8. Similar to #16727, reverting the move to assertions until the correct API to use for the combination of `matchTemplate` and `newStyleSynthesis` can be defined. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
) This reverts commit be6aa2e. This commit, coupled with the newStyleSynthesis flag (enabled by default on the v2 branch) do not play nicely together. This is due to the default resources present in every template (Parameter and Rule for checking bootstrap version). The `templateMatches` usage introduced in the original PR does not filter out these default inclusions, leading to most every of those tests to fail. Rather than block the forward merge on trying to come up with a clever solution, temporarily reverting. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…)" (aws#16740) This reverts commit 5e452f8. Similar to aws#16727, reverting the move to assertions until the correct API to use for the combination of `matchTemplate` and `newStyleSynthesis` can be defined. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit be6aa2e.
This commit, coupled with the newStyleSynthesis flag (enabled by default on the
v2 branch) do not play nicely together. This is due to the default resources
present in every template (Parameter and Rule for checking bootstrap version).
The
templateMatchesusage introduced in the original PR does not filter outthese default inclusions, leading to most every of those tests to fail. Rather
than block the forward merge on trying to come up with a clever solution,
temporarily reverting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license