Skip to content

feat(lambda-event-sources): self managed kafka: support sasl/plain authentication#16712

Merged
mergify[bot] merged 6 commits intoaws:masterfrom
tmokmss:add_basic_auth_for_self_managed_kafka
Oct 11, 2021
Merged

feat(lambda-event-sources): self managed kafka: support sasl/plain authentication#16712
mergify[bot] merged 6 commits intoaws:masterfrom
tmokmss:add_basic_auth_for_self_managed_kafka

Conversation

@tmokmss
Copy link
Copy Markdown
Contributor

@tmokmss tmokmss commented Sep 29, 2021 •
edited
Loading

closes #16710

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 29, 2021

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 29, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@tmokmss tmokmss changed the title add BASIC_AUTH authentication method for self-managed Kafka event source fix(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source Sep 29, 2021
@tmokmss tmokmss changed the title fix(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source feat(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source Sep 29, 2021
@tmokmss tmokmss changed the title feat(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source chore(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source Sep 29, 2021
@nija-at nija-at self-assigned this Oct 11, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Oct 11, 2021
nija-at
nija-at previously requested changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR.

Please add a unit test.

@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 11, 2021
@nija-at nija-at changed the title chore(lambda-event-sources): Add BASIC_AUTH authentication method for self-managed Kafka event source feat(lambda-event-sources): self managed kafka: support sasl/plain authentication Oct 11, 2021
@mergify mergify bot dismissed nija-at’s stale review October 11, 2021 10:42

Pull request has been modified.

@tmokmss
Copy link
Copy Markdown
Contributor Author

tmokmss commented Oct 11, 2021

@nija-at
Hi, thank you for the review! I added a unit test.

nija-at
nija-at approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 11, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2bc2215
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d4ad93f into aws:master Oct 11, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@tmokmss @TikiTDO
feat(lambda-event-sources): self managed kafka: support sasl/plain au…
9531198 
…thentication (aws#16712)

closes aws#16710


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nija-at nija-at nija-at approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

effort/small Small work item – less than a day of effort p2 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(lambda-event-sources): AuthenticationMethod: BASIC_AUTH is not supported for self-managed Kafka event source

3 participants

@tmokmss @aws-cdk-automation @nija-at