fix(cli): support CA bundle and proxy at the same time#16704
fix(cli): support CA bundle and proxy at the same time#16704zradlo1984 wants to merge 8 commits intoaws:masterfrom zradlo1984:feature/5804-support-both-ca-and-proxy-at-same-time
Conversation
924c117 to
ebfd5f2
Compare
|
I have merged from master and simplified somewhat. I hope this also works. Can you confirm if it does? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
left a comment
There was a problem hiding this comment.
Marking as "changes requested" to get it out of my queue. Feel free to re-request review after you can confirm this change also works. Cheers!
|
@rix0rrr And your solution tries to read HTTP_PROXY env variable only, but CDK has also command line parameters to set proxy. You cannot ignore command line parameters. You must read proxy settings like this: |
|
I am looking for source of this. It seems that it was introduced by commit ceab036 when somebody fixed #16751. He removed command line parameters reading and changed to create ProxyAgent without parameters. Now it is even worse. CDK does not support CA bundle and proxy at the same time and ignores --proxy command line parameter and it does not warn about this. |
|
So what should I do? It can't be merged as is now. |
|
@rix0rrr |
fixes #5804
This is solution I proposed 21.6.2021.
I use this solution in my work for 4 months and it works.
While we plan to use cdk in devops pipeline we need #5804 to be fixed in official cdk cli tool.
We cannot create custom modified version after each upgrade of CDK nor check and modify sdk-provider after each npm install.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license