chore(cli): add more capabilities to the hotswap CFN evaluate sub-system#16696
Merged
mergify[bot] merged 12 commits intoaws:masterfrom Sep 30, 2021
Merged
chore(cli): add more capabilities to the hotswap CFN evaluate sub-system#16696mergify[bot] merged 12 commits intoaws:masterfrom
mergify[bot] merged 12 commits intoaws:masterfrom
Conversation
… to be async, in preparation for using ListStackResources in it.
|
|
rix0rrr
reviewed
Sep 29, 2021
packages/aws-cdk/lib/api/hotswap/cloudformation-executable-template.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/api/hotswap/cloudformation-executable-template.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/api/hotswap/cloudformation-executable-template.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/api/hotswap/cloudformation-executable-template.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/api/hotswap/cloudformation-executable-template.ts
Outdated
Show resolved
Hide resolved
924c117 to
ebfd5f2
Compare
Contributor
Author
|
@rix0rrr thanks for the review! I've incorporated all of your comments, would appreciate another pass! |
rix0rrr
reviewed
Sep 30, 2021
packages/aws-cdk/lib/api/hotswap/evaluate-cloudformation-template.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Sep 30, 2021
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
Provisional okeedoke, do with my remaining comments as you will
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
…tem (#16696) The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited: only allows substituting the values of parameters used for Assets. That's not good enough when doing substitutions for StepFunctions State Machines from [this PR](#16489), for example. Enhance the capabilities of the CFN eval sub-system by introducing a new class, `CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…tem (aws#16696) The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited: only allows substituting the values of parameters used for Assets. That's not good enough when doing substitutions for StepFunctions State Machines from [this PR](aws#16489), for example. Enhance the capabilities of the CFN eval sub-system by introducing a new class, `CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited:
only allows substituting the values of parameters used for Assets.
That's not good enough when doing substitutions for StepFunctions State Machines from
this PR, for example.
Enhance the capabilities of the CFN eval sub-system by introducing a new class,
CloudFormationExecutableTemplate, that allows resolving references to resources inside the template.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license