feat(backup): expose method to add statements to the vault policy#16597
Merged
mergify[bot] merged 4 commits intoaws:masterfrom Sep 24, 2021
Merged
feat(backup): expose method to add statements to the vault policy#16597mergify[bot] merged 4 commits intoaws:masterfrom
mergify[bot] merged 4 commits intoaws:masterfrom
Conversation
|
|
Contributor
Author
kaizencc
previously requested changes
Sep 24, 2021
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Code looks good, just a tiny nit in the README and then we're good to go!
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
Pull request has been modified.
kaizencc
approved these changes
Sep 24, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ryparker
pushed a commit
that referenced
this pull request
Sep 24, 2021
…6597) Add `vault.addToAccessPolicy()` and `vault.blockRecoveryPointDeletion()`. A vault is automatically created when creating a plan: ```ts const plan = new backup.BackupPlan(this, 'BackupPlan'); ``` Theses methods allow, among other things, to customize the access policy of the automatically created vault: ```ts plan.backupVault.addToAccessPolicy(...); ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
vault.addToAccessPolicy()andvault.blockRecoveryPointDeletion().A vault is automatically created when creating a plan:
Theses methods allow, among other things, to customize the access policy of
the automatically created vault:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license